mpolden commented on code in PR #1925:
URL: https://github.com/apache/zookeeper/pull/1925#discussion_r978717753
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java:
##########
@@ -64,7 +66,8 @@ public void flush() throws IOException {
} catch (IOException e) {
LOG.warn("Closing connection to leader, exception during packet
send", e);
try {
- if (!learner.sock.isClosed()) {
+ Socket socket = learner.sock;
+ if ( socket != null && ! learner.sock.isClosed()) {
Review Comment:
Should probably use `socket` in the second condition too? In case it changes
after the first check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
