jonmv commented on PR #1925: URL: https://github.com/apache/zookeeper/pull/1925#issuecomment-1265325492
Hmm, no, the code has a race, as it is now. The `LeaderHandler` expects the first `ACK` after starting a `DIFF` sync to be the `NEWLEADER` ack, but if there are lots of `PROPOSAL`s in the diff, before the `NEWLEADER`, then this may also cause an `ACK` to be sent, which will crash the `Leader.wantForNewLeaderAck`. Ensuring the transactions are indeed flushed (through the usual request processor pipeline) _guarantees_ these `ACK`s, and thus always crashes the leader. Meh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
