li4wang commented on code in PR #1966:
URL: https://github.com/apache/zookeeper/pull/1966#discussion_r1116265331
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/CommandBase.java:
##########
@@ -28,22 +28,31 @@ public abstract class CommandBase implements Command {
private final Set<String> names;
private final String doc;
private final boolean serverRequired;
+ private final AuthRequest authRequest;
/**
* @param names The possible names of this command, with the primary name
first.
*/
protected CommandBase(List<String> names) {
- this(names, true, null);
+ this(names, true);
}
protected CommandBase(List<String> names, boolean serverRequired) {
this(names, serverRequired, null);
}
- protected CommandBase(List<String> names, boolean serverRequired, String
doc) {
+ protected CommandBase(List<String> names, boolean serverRequired,
AuthRequest authRequest) {
+ this(names, serverRequired, null, authRequest);
+ }
+
+ protected CommandBase(List<String> names, boolean serverRequired, String
doc, AuthRequest authRequest) {
Review Comment:
Doc is always null and not be used. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
