kezhuw opened a new pull request, #2001:
URL: https://github.com/apache/zookeeper/pull/2001

   Currently, there are 10 constructor variants for `ZooKeeper` and 4 for 
`ZooKeeperAdmin`. It is enough for us to resort to a builder.
   
   The `build` method throws `IOException` to make it a drop-in replacement of 
existing constructors of `ZooKeeper`.
   
   This pr also unify body of `ZooKeeper` constructor to one. Previously, there 
are diverged to two. One has `sessionId` and `sessionPasswd`, and another 
doesn't have. This pr uses `sessionId == 0` to differentiate the two as it is 
used in server side to differentiate session create and reconnect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to