w6et commented on PR #1774: URL: https://github.com/apache/zookeeper/pull/1774#issuecomment-1613614104
Maybe it's not a threads concurrently issue,just network broken from follower to leader (As @maoling guessed，I think so too)，learner.sock has been closed or assigned to null in Follower#followLeader or somewhere,It is possible so i think just check if (learner.sock != null) in SendAckRequestProcessor#flush,It's compatible and not bad more due to SendAckRequestProcessor#flush has been catched the NPE,but an exceptions always confusing. BTW,make Learner#closeSockSync() is synchronized doesn't make any sense(not sure Learner with in race condition so far) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
