kezhuw commented on code in PR #2051:
URL: https://github.com/apache/zookeeper/pull/2051#discussion_r1295802252
##########
zookeeper-server/src/main/java-filtered/org/apache/zookeeper/version/Info.java:
##########
@@ -25,5 +25,5 @@ public interface Info {
String QUALIFIER="${parsedVersion.qualifier}".isEmpty() ? null :
"${parsedVersion.qualifier}";
int REVISION=-1; //@deprecated, please use REVISION_HASH
String REVISION_HASH="${mvngit.commit.id}";
- String BUILD_DATE="${build.time}";
+ String BUILD_DATE="${project.build.outputDirectory}";
Review Comment:
Typo ? "outputDirectory" ==> "outputTimestamp" ?
##########
zookeeper-server/src/main/java-filtered/org/apache/zookeeper/version/VersionInfoMain.java:
##########
@@ -20,6 +20,6 @@
public class VersionInfoMain implements org.apache.zookeeper.version.Info {
public static void main(String[] args) {
- System.out.println("Apache ZooKeeper, version ${project.version}
${build.time}");
+ System.out.println("Apache ZooKeeper, version ${project.version}
${project.build.outputDirectory}");
Review Comment:
I think `mvngit.commit.abbrev` and
[`mvngit.commit.committer.date`](https://github.com/koraktor/mavanagaiata/blob/dc44108acc9399ecae5c60f8cbb2099f88ed0fef/src/main/java/com/github/koraktor/mavanagaiata/mojo/CommitMojo.java#L72)
is more appropriate for use to go. `mvngit.commit.abbrev` gives use
"15f29b5-dirty" and "cb22c82" depends on "dirty" working directory or not. It
is less verbose than `REVISION_HASH` which contains the full hash.
`mvngit.commit.committer.date` is configurable through
[SimpleDataFormat](https://github.com/koraktor/mavanagaiata/blob/8b3ee9c77d8e2a96a21df0789a7b5ca53e82f2c1/src/main/java/com/github/koraktor/mavanagaiata/mojo/AbstractGitMojo.java#L39),
I think we can output `UTC` timestamp as before using some template code if
demand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
