kezhuw commented on code in PR #2045:
URL: https://github.com/apache/zookeeper/pull/2045#discussion_r1295950920
##########
zookeeper-client/zookeeper-client-c/tests/TestReconfig.cc:
##########
@@ -499,7 +499,7 @@ class Zookeeper_reconfig : public CPPUNIT_NS::TestFixture
found = seen.find(next.str());
CPPUNIT_ASSERT_MESSAGE(next.str() + " in seen list",
found == string::npos);
- seen += found + ", ";
+ seen += next.str() + ", ";
Review Comment:
I think this is a bug but not a simple "nice to have". I experimented that
this `+=` will convert `found` from integer to char. cc @ztzg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
