tisonkun commented on code in PR #2118:
URL: https://github.com/apache/zookeeper/pull/2118#discussion_r1471510319
##########
zookeeper-server/src/main/resources/lib/netty-codec-4.1.105.Final.LICENSE.txt:
##########
@@ -1,7 +1,7 @@
Apache License
Version 2.0, January 2004
- http://www.apache.org/licenses/
+ https://www.apache.org/licenses/
Review Comment:
I agree. As long as we sort it out that "these deps are licensed under the
Apache License, 2.0" in LICENSE or NOTICE, we don't need to bundle all these
identical copy, like:
*
https://github.com/apache/kvrocks/blob/fd33e55d8e6fd9e674eef8711000ab03e6d87d76/NOTICE#L15-L31
*
https://github.com/apache/kvrocks/tree/fd33e55d8e6fd9e674eef8711000ab03e6d87d76/licenses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
