eolivelli commented on code in PR #2100: URL: https://github.com/apache/zookeeper/pull/2100#discussion_r1477029099
########## zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/Zab1_0Test.java: ########## @@ -69,15 +69,14 @@ import org.apache.zookeeper.txn.TxnHeader; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; import org.slf4j.Logger; import org.slf4j.LoggerFactory; public class Zab1_0Test extends ZKTestCase { private static final Logger LOG = LoggerFactory.getLogger(Zab1_0Test.class); - private static final File testData = new File(System.getProperty("test.data.dir", "src/test/resources/data")); Review Comment: is this correct ? is the test trying to read some existing file generated with an old version of ZK ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org