eolivelli commented on code in PR #2127:
URL: https://github.com/apache/zookeeper/pull/2127#discussion_r1481022680
##########
zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java:
##########
@@ -101,8 +100,8 @@ public class PrometheusMetricsProvider implements
MetricsProvider {
private final CollectorRegistry collectorRegistry =
CollectorRegistry.defaultRegistry;
private final RateLogger rateLogger = new RateLogger(LOG, 60 * 1000);
private String host = "0.0.0.0";
- private int port = 7000;
- private boolean exportJvmInfo = true;
+ protected int port = 7000;
Review Comment:
I would add support for a secondary port here instead of creating an
alternative metrics provider.
The Metrics Provider is the library/system that you use to export metrics,
and it should not be related to security/https
Can you please merge the two classes in one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
