kezhuw commented on code in PR #2166:
URL: https://github.com/apache/zookeeper/pull/2166#discussion_r1610760803
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/RequestPathMetricsCollector.java:
##########
@@ -140,6 +150,7 @@ static boolean isWriteOp(int requestType) {
case ZooDefs.OpCode.sync:
case ZooDefs.OpCode.create:
case ZooDefs.OpCode.create2:
+ case ZooDefs.OpCode.createTTL:
Review Comment:
I added only `createTTL` here.
* `addWatch` touches no persistent data but only volatile data.
* `check` itself modifies nothing. If data of the checking path is modified,
it will be tracked through another opcode.
* `reconfig` is here already.
Besides above, does `sync` considered as a write opcode ? I try to be
conservative to changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
