kezhuw commented on code in PR #2167:
URL: https://github.com/apache/zookeeper/pull/2167#discussion_r1636205147
##########
zookeeper-contrib/zookeeper-contrib-zkfuse/src/thread.h:
##########
@@ -41,7 +41,7 @@ class Thread {
void Create(void* ctx, ThreadFunc func);
void Join() {
- //avoid SEGFAULT because of unitialized mThread
+ //avoid SEGFAULT because of initialized mThread
Review Comment:
uninitialized ?
In case of uninitialized, `_func` should be `NULL`.
https://github.com/apache/zookeeper/blob/master/zookeeper-contrib/zookeeper-contrib-zkfuse/src/thread.cc#L27-L39
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java:
##########
@@ -295,7 +295,7 @@ protected long nanoTime() {
/**
* Overridable helper method to simply call sock.connect(). This can be
- * overriden in tests to fake connection success/failure for
connectToLeader.
+ * override in tests to fake connection success/failure for
connectToLeader.
Review Comment:
overridden ?
##########
zookeeper-server/src/test/java/org/apache/zookeeper/test/QuorumUtilTest.java:
##########
@@ -42,7 +42,7 @@ public class QuorumUtilTest extends ZKTestCase {
* <p>
* This test ensures that all JXM beans associated to a {@link QuorumPeer}
* are unregistered when shuted down ({@link QuorumUtil#shutdown(int)}). It
- * allows a successfull restarting of several zookeeper servers (
+ * allows a successfulrestarting of several zookeeper servers (
Review Comment:
missing space ?
##########
zookeeper-server/src/test/java/org/apache/zookeeper/test/GetProposalFromTxnTest.java:
##########
@@ -117,7 +117,7 @@ public void testGetProposalFromTxn() throws Exception {
}
// All zxid should match what we created
- assertTrue(Arrays.equals(zxids, retrievedZxids.toArray(new Long[0])),
"Zxids missmatches");
+ assertArrayEquals(zxids, retrievedZxids.toArray(new Long[0]), "Zxids
mismatches");
Review Comment:
+1 on this, though not only typos.
##########
zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/org/apache/zookeeper/inspector/gui/nodeviewer/NodeSelectionListener.java:
##########
@@ -18,7 +18,7 @@
package org.apache.zookeeper.inspector.gui.nodeviewer;
/**
- * An interface to be implented by any component that needs notification when
a new element
+ * An interface to be implement by any component that needs notification when
a new element
Review Comment:
implemented ?
##########
zookeeper-contrib/zookeeper-contrib-zkfuse/src/zkadapter.h:
##########
@@ -616,7 +616,7 @@ class ZooKeeperAdapter
/**
* Returns the remaining connect timeout. The timeout resets
- * to {@link #m_connectTimeout} on a successfull connection to the ZK.
+ * to {@link #m_connectTimeout} on a successfulconnection to the ZK.
Review Comment:
nit: missing space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
