frederiko commented on code in PR #2120:
URL: https://github.com/apache/zookeeper/pull/2120#discussion_r1741309171
##########
bin/zkEnv.sh:
##########
@@ -145,9 +145,15 @@ fi
#echo "CLASSPATH=$CLASSPATH"
# default heap for zookeeper server
-ZK_SERVER_HEAP="${ZK_SERVER_HEAP:-1000}"
-export SERVER_JVMFLAGS="-Xmx${ZK_SERVER_HEAP}m $SERVER_JVMFLAGS"
+if [[ -n $ZK_SERVER_HEAP ]]; then
+ echo 'WARNING: ZK_SERVER_HEAP will not be recognized in a future version.
Set -Xmx directly using SERVER_JVMFLAGS instead.'
+ SERVER_JVMFLAGS="-Xmx${ZK_SERVER_HEAP}m $SERVER_JVMFLAGS"
+fi
+export SERVER_JVMFLAGS=${SERVER_JVMFLAGS:--Xmx1000m}
Review Comment:
I think I will leave this PR behind. In my tests, I did not see it breaking,
but I'm may be wrong. As it is, I just think it's too complicate should one
want to set HEAP based the amount of memory available, especially in containers
orchestration platforms. Let's close it and hopefully someday we can address it
again. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
