ctubbsii opened a new pull request, #2224: URL: https://github.com/apache/zookeeper/pull/2224
* Run `shfmt -ln bash -l -d -i 2 -ci -s bin/` and apply changes to format scripts * Standardize on double square braces to avoid unpredictable use of /usr/bin/\[ instead of built-in bash braces * Fix all shellcheck issues * Export CLASSPATH from zkEnv.sh and remove `-cp $CLASSPATH`, so that java picks up the classpath from the environment, to avoid absurdly long command lines in process listings (this should also fix an issue with older versions of pgrep/pkill, such as that installed on RHEL8; see https://bugzilla.redhat.com/show_bug.cgi?id=1782309 for details) * Add a new `classpath` command to print the CLASSPATH environment variable in the form `CLASSPATH=$CLASSPATH` from the script, so that the script's view of the CLASSPATH environment can easily be inspected when troubleshooting java processes * Remove a useless check of `$?` in bin/zkServer-initialize.sh * Remove an impossible to reach exit from bin/zkServer-initialize.sh * Remove an impossible to fail check of `$?` after nohup is executed in bin/zkServer.sh (nohup with a trailing `&` always returns a zero exit code for success, even if the command fails; if it fails it fails undetectibly in the background) * Avoid using sed for regex, and use built-in bash regex instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
