stoty commented on code in PR #2270:
URL: https://github.com/apache/zookeeper/pull/2270#discussion_r2212246941
##########
zookeeper-server/src/main/java/org/apache/zookeeper/common/ClientX509Util.java:
##########
@@ -99,6 +113,14 @@ public SslContext createNettySslContextForClient(ZKConfig
config)
}
}
+ private void logTcnativeOcsp(boolean enable) {
+ if (enable && !OpenSsl.isOcspSupported()) {
+ // SslContextBuilder.enableOcsp() doesn't do anything, unless the
default BoringSSL
+ // tcnative dependency is replaced with an OpenSsl one.
+ LOG.warn("Trying to enable OCSP for tcnative OpenSSL provider, but
it is not supported. The setting will be ignored");
Review Comment:
The Enum default: "JRE"/"OPENSSL"/"OPENSSL_REFCNT"
I have added the version string to the error message (which won't ever
trigger unless tcnative fixes OpenSSL.isOcspSupported().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
