ctubbsii commented on PR #2297: URL: https://github.com/apache/zookeeper/pull/2297#issuecomment-3194541903
@anmolnar wrote: > ... that's only the dependency check. ... the JDK8 build is not broken. I agree with that, and I support the change you made (the gray checkmark on my review indicates a non-binding "Approve" for your PR). I am only suggesting that making JDK11 the minimum for all the tasks in the POM will be more convenient than having a special workaround for OWASP only. > I don't think users want to run the dependency check on their own. Many won't, but since the ASF's mission is to produce open source software, we should expect that *some* downstream users will build from source. The inconvenience for the ZK release manager is also an inconvenience for those users who want to run the tasks for themselves. > We need to update our release process page, because after this change release managers will no longer be able to run the dependency check with JDK8 and we also need to update the docker image to use JDK11 as default java runtime. That is satisfactory, but I think it's an inconvenience to have two separate minimum versions, depending on which tasks one executes. Also, there are other reasons to standardize on the minimum being JDK11 for everything: 1. in this case, only OWASP requires a different minimum JDK... but next time, a plugin that is part of the main build might require JDK11. Making JDK11 the minimum for everything would help avoid such problems in the future, 2. older JDK versions are increasingly harder to acquire in newer operating systems and corporate environments where security policies prevent the use of older software, so fewer people over time are actually building and testing with JDK8; so, continuing to support it is increasingly a waste of effort, 3. JDK11 has stricter Java 8 compliance enforcement than JDK 8 does, so it's better to build with JDK11 if you want to support JRE8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
