kezhuw commented on code in PR #2307:
URL: https://github.com/apache/zookeeper/pull/2307#discussion_r2352647807
##########
zookeeper-assembly/pom.xml:
##########
@@ -64,12 +64,6 @@
<artifactId>zookeeper</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.zookeeper</groupId>
- <artifactId>zookeeper-client</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- </dependency>
Review Comment:
> ZooKeeper isn't doing any of that, so it's probably okay for
zookeeper-common to be included transitively, but I would probably include it
to try to achieve some consistency.
Done in 6120e83.
> using a somewhat convoluted process so we just declare what we want in the
POM, and only those things get included.
Out of curiosity, why do you route to this path ? It seems more complicated
than transitive approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
