On 11/07/11 20:03 -0400, Austin Clements wrote:
> > > The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE
> > > (though, admittedly, I don't know why; avoiding C99-isms?)
> >
> > And bool is already used at another place in message.cc:
> >
> > struct maildir_flag_tag {
> > char flag;
> > const char *tag;
> > bool inverse;
> > };
> >
> > IIUC it should be changed to notmuch_bool_t too.
>
> Yes, I suppose it should (something slipped by cworth's eagle-eyed
> reviews!). Though that appears to be the sole use of bool in all of
> libnotmuch.
I wonder if this is due to incompatible definitions of type bool in C99 and
C++. In that case this is probably harmless since struct maildir_flag_tag is
only visible from message.cc. Anyway, I'm sending a conversion patch together
with the updated series to make it clearer for Carl.
Thanks,
Louis
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
