Hi Jameson. On Thu, 17 Nov 2011 01:14:07 -0800, Jameson Graef Rollins <jroll...@finestructure.net> wrote: > On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin > <dmitry.kuroch...@gmail.com> wrote: > > The following patch series is an attempt to introduce proper > > dependencies for external binaries in a less intrusive way than > > [1]. The primary aim was to avoid changing every subtest that > > uses external binaries. > > Hey, Dmitry. Thanks so much for reworking Pieter's original test suite > improvements. I think this new approach is a bit less invasive and a > little more elegant to work with. > > I've looked through the patchs, and they all look ok on first glance > (barring any possibly needed modifications that I'm not seeing). I have > a couple of comments to follow. > > However, when I tried to test the tests with the patch applied I ran > into one problem. If I try to run the test suite with dtach > uninstalled, it looks like I'm experiencing a hang on > emacs_deliver_message call. I wonder if either emacs_deliver_message or > test_emacs is not doing the right thing in the case of no dtach. I > think emacs_deliver_message should somehow not require dtach, since it's > not actually testing any display stuff, but because it's currently using > test_emacs, it is somehow implicitly depending on it. Any thoughts on > how to fix that? >
I bet you stumbled upon a hanging smtp-dummy. There is a patch [1] to fix that. Hopefully it would get pushed soon. As for not requiring dtach for emacs_deliver_message, that is definitely possible. Currently, there is only one way to run emacs to keep it simple. And I am not sure if running emacs_deliver_message without dtach costs extra code. Regards, Dmitry [1] id:"yf639dnsqtc....@taco2.nixu.fi" > jamie. _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
