Quoth Daniel Kahn Gillmor on Dec 27 at 9:27 am: > On 12/23/2011 10:45 PM, Austin Clements wrote: > > Quoth Dmitry Kurochkin on Dec 10 at 3:25 am: > >> + /* For some reason the GMimeSignatureValidity returned > >> + * here is not a const (inconsistent with that > >> + * returned by > >> + * g_mime_multipart_encrypted_get_signature_validity, > >> + * and therefore needs to be properly disposed of. > >> + * Hopefully the API will become more consistent. */ > >> > >> Ouch. In gmime 2.6 this API has changed, but looks like the > >> issue is still there. Is there a bug for it? If yes, we should > >> add a reference to the comment. Otherwise, we should file the > >> bug and then add a reference to the comment :) > > > > It looks like they're both non-const in 2.6 (which makes more sense to > > me). I updated the comment to mention this. > > Here's the bug report where this was discussed with upstream, fwiw: > > https://bugzilla.gnome.org/show_bug.cgi?id=640911
Oh, are we not supposed to be disposing of the GMimeSignatureValidity returned by g_mime_multipart_encrypted_get_signature_validity ourselves? Comment 1 on that bug report suggests that we shouldn't. The old show code did, so I ported that behavior over to the new code. _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch