On Tue, 10 Jan 2012 18:56:29 -0800, Jameson Graef Rollins <jroll...@finestructure.net> wrote: > Actually, the show-next argument was already part of the function. I > did not introduce it. And it wasn't optional originally, so if we want > to change that behavior we should probably do so in a separate patch.
Hrm. I didn’t communicate as clearly as I could have – you are correct that the show-next argument to the notmuch-show-archive-internal function was pre-existing. But notmuch-show-tag-thread-internal is a new function, with potentially expanded usefulness to third-party code. Thus I think I’m in the clear to bikeshed about its calling convention. :) It’s your patch, though, so it’s your call if you feel that the &optional goes best in a new change. -- Aaron Ecay _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
