On Thu, 26 Jan 2012 08:46:00 +0000, David Edmondson <d...@dme.org> wrote: > On Thu, 26 Jan 2012 05:47:07 +0400, Dmitry Kurochkin > <dmitry.kuroch...@gmail.com> wrote: > > > > + ;; Perform some validation > > > > + (let ((words action)) > > > > + (when (null words) (error "No operation given")) > > > > + (while words > > > > + (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words)) > > > > + (error "Action must be of the form `+thistag -that_tag'")) > > > > + (setq words (cdr words)))) > > > > > > This should really be a mapc or a dolist, but maybe that's for another > > > patch. > > > > Yes, I changed "this_tag" spelling in v2, but would prefer to leave > > non-trivial changes in this code for another patch. > > If you were going to submit another patch then fine, but the chances are > it will just get forgotten.
No worries, v5 has a cleanup patch added :) Regards, Dmitry _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
