Quoth Jani Nikula on Feb 06 at 7:54 am: > On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements <amdra...@mit.edu> wrote: > > Yikes. I don't envy you this patch. Two minor nits, otherwise this > > and the next patch LGTM. > > Thanks for the review. I'll roll another version, I think it will be > better with your suggestions incorporated. > > > Quoth Jani Nikula on Feb 04 at 12:41 am: > > > Use the new notmuch argument parser to handle arguments in "notmuch > > > show". There are two corner case functional changes: > > > > > > 1) Also set params.raw = 1 when defaulting to raw format when part is > > > requested but format is not specified. > > > > Huh. So "notmuch show --part=0 <query>" was broken before. > > Hmm, yes, it seems so. Do you think I should make this a separate fix?
I wouldn't bother. Since this usage would throw --format=raw into "useless mode", clearly no one cared. No sense throwing good code after bad. _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch