Hi Pieter. On Wed, 25 Jan 2012 06:25:39 +0100, Pieter Praet <pie...@praet.org> wrote: > * emacs/notmuch-show.el (notmuch-show-open-or-close-all): > Rename to `notmuch-show-toggle-all-messages', and make it toggle > visibility of all messages based on the visibility of the current > message, instead of setting visibility based on whether or not a > prefix arg was supplied. > > Same functionality, less effort (reaching for 'C-u' is a pain)... > > --- > emacs/notmuch-show.el | 22 ++++++++++++---------- > 1 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index e6a5b31..2d17f74 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -1050,8 +1050,8 @@ thread id. If a prefix is given, crypto processing is > toggled." > (define-key map "p" 'notmuch-show-previous-open-message) > (define-key map (kbd "DEL") 'notmuch-show-rewind) > (define-key map " " 'notmuch-show-advance-and-archive) > - (define-key map (kbd "M-RET") 'notmuch-show-open-or-close-all) > (define-key map (kbd "RET") 'notmuch-show-toggle-message) > + (define-key map (kbd "M-RET") 'notmuch-show-toggle-all-messages)
Should the function name include "visible" or "visibility" to make it clear what is toggled? E.g. `notmuch-show-toggle-visibility-all'. Also, consider changing "all-messages" to just "all" or "thread". That seems to be more consistent with other functions. > (define-key map "#" 'notmuch-show-print-message) > map) > "Keymap for \"notmuch show\" buffers.") > @@ -1502,16 +1502,18 @@ the result." > (not (plist-get props :message-visible)))) > (force-window-update)) > > -(defun notmuch-show-open-or-close-all () > - "Set the visibility all of the messages in the current thread. > -By default make all of the messages visible. With a prefix > -argument, hide all of the messages." > +(defun notmuch-show-toggle-all-messages () > + "Toggle the visibility of all messages in the current thread. > +If the current message is visible, hide all messages -- and vice versa." > (interactive) > - (save-excursion > - (goto-char (point-min)) > - (loop do (notmuch-show-message-visible > (notmuch-show-get-message-properties) > - (not current-prefix-arg)) > - until (not (notmuch-show-goto-message-next)))) > + (let ((toggle (notmuch-show-message-visible-p))) Please rename "toggle" to "visible-p". That would make it more clear what the variable means, and is consistent with `notmuch-show-message-visible-p'. > + (save-excursion > + (goto-char (point-min)) > + (loop do (notmuch-show-message-visible > + (notmuch-show-get-message-properties) > + (not toggle)) > + until (not (notmuch-show-goto-message-next))))) A new `notmuch-show-mapc' function was introduced in a recent commit. Please use it here instead of a custom loop. > + (recenter-top-bottom 1) There was no `recenter-top-bottom' call before. Why is it needed now? It seems like an independent change and, if it is needed, would be better as a separate patch. At the very least, it's worth mentioning in the preamble and perhaps in a comment. Regards, Dmitry > (force-window-update)) > > (defun notmuch-show-next-button () > -- > 1.7.8.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch