On Sat, 14 Apr 2012, Peter Wang <noval...@gmail.com> wrote: > Changes from v3: > - rephrase part of the 'list' implementation as a separate patch > - test 'set' on an extant key > - test removing keys
This looks good to me. +1 Two minor comments which you might like to consider (but definitely are not required): 1) You could check that there are no further arguments when the user calls `notmuch config list' 2) In the man page you could explicitly say what the output is for a configuration item which has not been set. Best wishes Mark > Peter Wang (6): > config: Fix free in 'config get' implementation. > config: Check 'config get' arity exactly > test: Add tests for 'config' command > test: Add broken test for 'config list' > config: Add 'config list' command > man: Document 'config list' command > > man/man1/notmuch-config.1 | 14 +++++++++ > notmuch-config.c | 68 +++++++++++++++++++++++++++++++++++++++++--- > test/config | 60 +++++++++++++++++++++++++++++++++++++++ > test/notmuch-test | 1 + > 4 files changed, 138 insertions(+), 5 deletions(-) > create mode 100755 test/config > > -- > 1.7.4.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch