I have reviewed all the new parts of this series (judged as being patches 3-8) and the changes made to my two patches and they are all fine (with one small comment below). Patch 1/8 does need a proper review though as it ended up more intrusive than I would have liked.
> +Messages matching search.tag_exclude are called "excluded messages". My one comment is that this is not quite true if the corresponding tag is in the query. Since you are defining the term it would be nice to mention that, but I can't see a clean wording. This should not hold up the series as it your wording is clearly an improvement on the current wording. Best wishes Mark _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch