Mark Walters <markwalters1...@gmail.com> writes: > Hello > > Notmuch pick is an emacs view which displays a threaded view of > messages: each message has its own line and the thread structure is > shown with UTF-8 graphics characters (so it looks vaguely similar to > mutt's threaded view): see http://kanelephant.com/screen.png for a screenshot. > > Pick was originally written by David Edmondon and posted on irc and I > have been developing it on and off since. Now that almost all the > backend changes it uses are in I would like to see about getting it > into mainline. > > The code is not of the same standard as mainline code: in particular a > lot of the code is written by me and is working but unidiomatic > lisp. It has also not had widespread testing so I would expect it to > have several bugs. > > We could try getting it into mainline using the normal review type > approach, but the patch is necessarily large (it implements a new view > similar in size to show or search) with the main pick.el file being > nearly 900 lines. > > An alternative approach would be to accept it into contrib and then > reviewers/users could submit fixes for the problems directly. > > This patch series implements the latter approach, but I am definitely > happy to try for the former or some other approach. >
I have been using this series for a long time and have not found any issues. How about adding pick as a part of proper emacs file and have a config value that disables pick by default. ? So only when notmuch-enable-pick is set we will load notmuch-pick.el ? > In its current form the user needs to copy (or link) the > notmuch-pick.el from contrib into the emacs directory and then build > notmuch as usual. With that users won't require to do the above. >There are two very small patches to "mainline" code: > one to compile and load the pick file if present and one small tweak > to notmuch-show.el. Then in contrib/notmuch-pick there are three > files: the notmuch-pick.el file itself, a README describing > documenting install and use, and a TODO which contains the main things > I think need doing (and I will try to update this in light of comments > received). > -aneesh _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
