Hi The overall series looks good to me +1.
I do like the slight tweak suggested by Michal in id:"xa1tipbvwdb0....@mina86.com" (but don't feel strongly). Also, ideally there should be some tests, particularly for the multiple tag case as I imagine most people will just have a single tag so breakage would be unnoticed. However, neither of these should hold up the series. Finally: > An interesting by-product is that you can filter your mail into multiple > different inboxes, each with their own inbox tag, and (after you setup > `notmuch-archive-tags') you can read and archive each inbox separately > with built-in archiving functions. I am assuming that you are suggesting adding -inbox1 -inbox2 etc to notmuch-archive-tags? So the "unarchive" option will not work in this case? (This is *definitely* not a complaint: just a query in case I am missing something) Best wishes Mark > > BR, > Jani. > > > Jani Nikula (6): > emacs: add helper for tag change list manipulation > emacs: fix notmuch-message-replied-tags defcustom type > emacs: use new tag change helper to mark messages as replied > emacs: add support for custom tag changes on message/thread archive > emacs: add support for reversing notmuch-search-archive-thread tag > changes > emacs: add support for reversing notmuch-show-mark-read tag changes > > emacs/notmuch-lib.el | 14 ++++++++++++ > emacs/notmuch-message.el | 26 ++++++++++------------ > emacs/notmuch-show.el | 54 > +++++++++++++++++++++++++++++++--------------- > emacs/notmuch-tag.el | 17 +++++++++++++++ > emacs/notmuch.el | 16 ++++++++++---- > 5 files changed, 91 insertions(+), 36 deletions(-) > > -- > 1.7.9.5 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch