Hi I thought I had checked the test output but I am getting a failure: the last test in emacs-show is failing (test_begin_subtest "id buttonization")
I think it is just saying your patch is working and making the tag inbox in the message line a button. Best wishes Mark On Thu, 13 Dec 2012, Damien Cassou <damien.cas...@gmail.com> wrote: > Signed-off-by: Damien Cassou <damien.cas...@gmail.com> > --- > test/emacs | 103 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 103 insertions(+) > > diff --git a/test/emacs b/test/emacs > index 5403930..af9d37c 100755 > --- a/test/emacs > +++ b/test/emacs > @@ -852,5 +852,108 @@ test_emacs "(let ((mm-text-html-renderer > test_expect_success "Rendering HTML mail with images" \ > 'cat OUTPUT && grep -q smiley OUTPUT' > > +test_begin_subtest "Extracting all tags from a thread" > +add_message \ > + '[subject]="Extracting all tags from a thread"' \ > + '[body]="body 1"' > +parent=${gen_msg_id} > +add_message \ > + '[subject]="Extracting all tags from a thread"' \ > + '[body]="body 2"' \ > + "[in-reply-to]=\<$parent\>" > +add_message \ > + '[subject]="Extracting all tags from a thread"' \ > + '[body]="body 3"' \ > + "[in-reply-to]=\<$parent\>" > +latest=${gen_msg_id} > +# Extract the thread-id from one of the emails > +thread_id=$(notmuch search --output=threads id:${latest}) > +echo THREAD ID: '"'$thread_id'"' > +# Add tag "mytagfoo" to one of the emails > +notmuch tag +mytagfoo id:${latest} > +test_emacs_expect_t \ > + "(notmuch-show \"${thread_id}\") > + (let ((output (notmuch-show-thread-tags)) > + (expected '(\"inbox\" \"mytagfoo\" \"unread\"))) > + (notmuch-test-expect-equal > + (sort output #'string<) > + (sort expected #'string<)))" > + > +test_begin_subtest "The tags appear in the header-line of notmuch-show" > +add_message \ > + '[subject]="foo bar"' \ > + '[body]="body 1"' > +latest=${gen_msg_id} > +# Add tag "mytagfoo" to one of the emails > +notmuch tag +mytagfoo id:${latest} > +# Extract the thread-id from one of the emails > +thread_id=$(notmuch search --output=threads id:${latest}) > +test_emacs_expect_t \ > + "(notmuch-show \"${thread_id}\") > + (if (string-match-p \"mytagfoo\" (format-mode-line header-line-format)) > + t > + \"The tag 'mytagfoo' was not in the header-line-format\")" > + > +test_begin_subtest "The tags appear in the header-line of notmuch-show even > after update" > +add_message \ > + '[subject]="foo bar"' \ > + '[body]="body 1"' > +latest=${gen_msg_id} > +# Extract the thread-id from one of the emails > +thread_id=$(notmuch search --output=threads id:${latest}) > +test_emacs_expect_t \ > + "(notmuch-show \"${thread_id}\") > + (if (string-match-p \"mytagfoo\" (format-mode-line header-line-format)) > + (error \"There is no reason for 'mytagfoo' to be there.\")) > + (notmuch-show-tag \"+mytagfoo\") > + (if (string-match-p \"mytagfoo\" (format-mode-line header-line-format)) > + t > + \"The tag 'mytagfoo' was not in the header-line-format\")" > + > +test_begin_subtest "The tags of notmuch-show emails are clickable" > +add_message \ > + '[subject]="foo bar"' \ > + '[body]="body 1"' > +latest=${gen_msg_id} > +# Add tag "mytagfoo" to one of the emails > +notmuch tag +mytagfoo id:${latest} > +# Extract the thread-id from one of the emails > +thread_id=$(notmuch search --output=threads id:${latest}) > +test_emacs_expect_t \ > + "(notmuch-show \"${thread_id}\") > + (goto-char (point-min)) > + (re-search-forward \"mytagfoo\") > + (backward-char) ;; to be 'in' the tag > + (unless (eq major-mode 'notmuch-show-mode) > + (error \"We must be in notmuch-show at this point but we are in %s.\" > major-mode)) > + (push-button) ;; simulate a press on the RET key > + (if (eq major-mode 'notmuch-search-mode) > + t > + (format \"We must be in notmuch-search at this point but we are in > %s.\" major-mode))" > + > +test_begin_subtest "The tags of notmuch-show emails are clickable even after > update" > +add_message \ > + '[subject]="foo bar"' \ > + '[body]="body 1"' > +latest=${gen_msg_id} > +# Extract the thread-id from one of the emails > +thread_id=$(notmuch search --output=threads id:${latest}) > +test_emacs_expect_t \ > + "(notmuch-show \"${thread_id}\") > + (goto-char (point-min)) > + (if (re-search-forward \"mytagfoo\" nil t) > + (error \"There is no reason for 'mytagfoo' to be there.\")) > + (notmuch-show-tag \"+mytagfoo\") > + (goto-char (point-min)) > + (unless (re-search-forward \"mytagfoo\" nil t) > + (error \"The tag 'mytagfoo' must have been there.\")) > + (backward-char) ;; to be 'in' the tag > + (unless (eq major-mode 'notmuch-show-mode) > + (error \"We must be in notmuch-show at this point but we are in %s.\" > major-mode)) > + (push-button) ;; simulate a press on the RET key > + (if (eq major-mode 'notmuch-search-mode) > + t > + (format \"We must be in notmuch-search at this point but we are in > %s.\" major-mode))" > + > > test_done > -- > 1.7.10.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch