On Tue, Apr 09 2013, Jed Brown wrote: > David Bremner <da...@tethera.net> writes: > >> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to >> do it myself. > > I tested the attached and it's working as expected. Sent as an > attachment to preserve author information.
LGTM (this time tested, too). Also compared diffs by hand, change as announced. comments in id:m26207wgyt....@guru.guru-group.fi (amend!) apply. Tomi >>From 5404ac5bf13f8b5349d5b94f9f2000e9d1832b83 Mon Sep 17 00:00:00 2001 > From: Daniel Bergey <ber...@alum.mit.edu> > Date: Mon, 8 Apr 2013 19:55:04 -0500 > Subject: [PATCH] emacs: functions to import sender or recipient into BBDB [v2] > >>From a show buffer, notmuch-bbdb/snarf-from imports the sender into > bbdb. notmuch-bbdb/snarf-to imports all recipients. Newly imported > contacts are reported in the minibuffer / Messages buffer. > > Both functions use the BBDB parser to recognize email address formats. > > [v2] Fixes missing close parenthesis in original. > Spotted by Karl Fogel <kfo...@red-bean.com>. > --- > emacs/notmuch-address.el | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el > index 2bf762b..4eda098 100644 > --- a/emacs/notmuch-address.el > +++ b/emacs/notmuch-address.el > @@ -96,6 +96,47 @@ line." > (when (notmuch-address-locate-command notmuch-address-command) > (notmuch-address-message-insinuate)) > > +;; functions to add sender / recipients to BBDB > + > +(defun notmuch-bbdb/snarf-headers (headers) > + ;; Helper function to avoid code duplication in the two below > + ;; headers should have the same format as bbdb-get-addresses-headers > + > + ;; bbdb-get-addresses reads these > + ;; Ugh, pass-by-global > + (let ((addrs (bbdb-get-addresses nil nil 'notmuch-bbdb/get-header-content)) > + (bbdb-get-addresses-headers headers) ; headers to read > + (bbdb-gag-messages t)) ; suppress m/n processed message) > + (bbdb-update-records addrs t t))) > + > +(defun notmuch-bbdb/snarf-from () > + "Import the sender of the current message into BBDB" > + (interactive) > + (notmuch-bbdb/snarf-headers > + (list (assoc 'authors bbdb-get-addresses-headers)))) > + > +(defun notmuch-bbdb/snarf-to () > + "Import all recipients of the current message into BBDB" > + (interactive) > + (notmuch-bbdb/snarf-headers > + (list (assoc 'recipients bbdb-get-addresses-headers)))) > + > +(defvar notmuch-bbdb/header-by-name > + ;; both are case sensitive > + '( ("From" . :From) > + ("To" . :To) > + ("CC" . :Cc) > + ("BCC" . :Bcc) > + ("Resent-From" . nil) > + ("Reply-To" . nil) > + ("Resent-To" . nil) > + ("Resent-CC" . nil)) > + "Alist for dispatching header symbols as used by notmuch-show-get-header > +from strings as used by bbdb-get-addresses") > + > +(defun notmuch-bbdb/get-header-content (name) > + (notmuch-show-get-header (cdr (assoc name notmuch-bbdb/header-by-name)))) > + > ;; > > (provide 'notmuch-address) > -- > 1.8.2.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch