LGTM.
Quoth Mark Walters on Sep 02 at 7:56 pm: > default-value needs its argument to be quoted. > > Slightly strangely default-value of 't or nil is 't or nil > respectively so the code > > (default-value notmuch-search-oldest-first) > > just gives the current value of notmuch-search-oldest-first rather > than intended default-value of this variable. > > The symptom is that if you are in a search buffer and use notmuch jump > to run a saved search which does not have an explicitly set sort order > then the sort order of the saved-search is inherited from the current > search buffer rather than being the default search order. > > Thanks to Jani for finding the bug. > --- > > This time with a fuller commit message. > > (Part of the reason I did not send more before is I had not checked > what the exact outcome of the buggy code was: it was obvious what the > code was intended to do, and that with the extra quote it > would do what it was intended to do.) > > Best wishes > > Mark > > > > > > > > emacs/notmuch-jump.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el > index 5eb0949..0193f8c 100644 > --- a/emacs/notmuch-jump.el > +++ b/emacs/notmuch-jump.el > @@ -51,7 +51,7 @@ (defun notmuch-jump-search () > (case (plist-get saved-search :sort-order) > (newest-first nil) > (oldest-first t) > - (otherwise (default-value notmuch-search-oldest-first))))) > + (otherwise (default-value 'notmuch-search-oldest-first))))) > (push (list key name > `(lambda () (notmuch-search ',query ',oldest-first))) > action-map))))) _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch