On Fri, 11 Dec 2009 11:01:15 +0530, "Aneesh Kumar K. V" <aneesh.kumar at
linux.vnet.ibm.com> wrote:
> On Fri, 04 Dec 2009 11:07:54 -0800, Carl Worth <cworth at cworth.org> wrote:
> > On Thu, 3 Dec 2009 14:16:44 +0530, "Aneesh Kumar K.V" <aneesh.kumar at
> > linux.vnet.ibm.com> wrote:
> > >
> > > This patch add --format=sender-only option.
> >
> > I like the idea here, (and agree that an 'R' keybinding would be great).
> >
> > But surely there's a way to implement this with dramatically less code
> > duplication?
>
> I sent an updated patch which did the above with less code duplication. Any
> chance of getting this merged ?
Thanks for the updated patch, (and I sincerely apologize for my late
response).
I still like the functionality and keybinding, and it's great to see
less code duplication in this patch, but I also agree with the point Jed
made:
I think --format= should not be used for this, formatting is orthogonal
to selecting recipients.
We're already using --format for selection JSON output, for example. And
it's not totally unreasonable to expect that someone might want JSON
output from "notmuch reply" as well. So let's use a separate option
here.
Perhaps:
--recipient=all|sender
or so?
-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20100309/7bc196cd/attachment.pgp>
