On Thu, 8 Apr 2010 16:42:42 +0200, Michal Sojka <sojkam1 at fel.cvut.cz> wrote: > My biggest question relates to the first patch, which does an > incompatible change to libnotmuch API. After reading RELEASING file, I > found that this change is probably not what Carl wants to merge (and I > understand that) so I'd like to get some feedback on my suggestion in > that patch.
[I composed this message a while ago, but failed to get it through the mailing-list moderation until now. It may be largely irrelevant in light of my more recent review of the mailstore abstraction, but here it is.] I haven't looked closely at the implementation here, but a quick glance at the API/ABI change suggests an easy answer: Why not just add a new function that accepts the mailstore type, and preserve the original function, (which would then simply call the new function with an argument of "files" for the mailstore type). -Carl -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100413/fa35bb5e/attachment.pgp>