On Fri, 05 Nov 2010, Michal Sojka wrote: > On Thu, 04 Nov 2010, David Edmondson wrote: > > On Thu, 04 Nov 2010 15:12:53 +0100, Michal Sojka <sojkam1 at fel.cvut.cz> > > wrote: > > > > Michal, was this addressed by the patch that Carl recently merged? > > > > (Commit f99ad42da03afd638bfdfdea92d1cbdd3b510b8f in my copy of the > > > > repository.) > > > > > > Unfortunately not. In your patch, the overlay changes the color/face of > > > the > > > whole line while my patch change the color/face of all parts of the line > > > except for non-matching authors. With my patch non-matched autors were > > > > I understand now. > > > > > This seems somewhat like a policy decision, though. If I indicate that I > > want the foreground text for a particular line to be red, should the > > formatting of non-matching authors override that? > > > > (My own approach has been to have `notmuch-search-line-faces' always > > specify a background colour whereas > > `notmuch-search-non-matching-authors' (or any of the columnar faces) > > specify a foreground colour and/or slant.) > > And now I even understand your patch. That's exactly what I wanted. > Nice. I thought that overlays change completely the face of the line, > hiding any faces "under" the overlay. Now I see, that > notmuch-search-line-faces faces are combined with what was there > before.
However, it seems that chaning :background in notmuch-search-line-faces collides somewhat with hl-line-mode. If I move the point down to the line with changed background, the line is not highlited. Only if I move the point upwards, I see the line in green. -Michal
