On Wed, 27 Apr 2011 18:30:09 +0200, Xavier Maillard <xavier at maillard.im> wrote: > On Mon, 25 Apr 2011 15:23:41 -0700, Carl Worth <cworth at cworth.org> wrote: > > On Wed, 17 Nov 2010 23:20:26 +0100, Matthieu Lemerre <racin at free.fr> > > wrote: > > > Maybe it would also be interesting to add a warning/assertion to check > > > that all email adresses added to the database are correct email > > > addresses? I.e. check that the `addr' variable in _index_address_mailbox > > > always has a @. This check is in fact already done using the function > > > strchr, but a bad value is explicitly ignored... > > > > Hmm... we could add a warning like that. But I don't know how useful it > > would actually be. (I, for one, am currently not seeing any warnings > > From "notmuch new"---maybe I should fix that...). > > > > Since GMime is fixed upstream (as of version 2.4.18) another option > > would be to simply make the notmuch build system require a sufficiently > > new version of GMime in order to build. > > > > What do you think? > > My vote goes to the latter. Cleaner and really simple solution. > > /Xavier > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
I'd say both. Unfortunately, regressions are not uncommon, and regardless, it'd be nice to be notified when what we stuff in the db is not sane. It would however be a good idea IMHO to check email address more thorougly [1] than simply verifying whether an "@" is present. Peace -Pieter [1] http://www.regular-expressions.info/email.html
