On Wed, 25 May 2011 23:21:54 +0200, Daniel Schoepe <daniel.schoepe at googlemail.com> wrote: > I incorporated most of you recommendations in the attached patch.
Looks good, thanks! I've pushed this out now. I only have two suggestions: 1. Could you please add some basic testing for this? The existing notmuch-hello tests should make a good starting point. 2. The hello screen is now lying a bit by saying "all tags". Perhaps if the user has the notmuch-hello-hide-tags variable set to non-nil the text might change somewhat? I'm not sure to what exactly. -Carl -- carl.d.worth at intel.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110526/a9e24561/attachment-0001.pgp>