On Mon, 3 Oct 2011 18:47:14 +0200, Thomas Jost <schnouki at schnouki.net> wrote: > Here it is: a rebased version of Pieter's patch series adding prereqs for the > emacs and crypto tests [1], and Dmitry's patches for running emacs inside > screen > in the test suite [2]. (Please note that this one also includes fixes to > improve > hidden signatures handling in notmuch-show-advance-and-archive.) >
I'm pleased to see these patches haven't moved to binary oblivion yet! > I had to do several changes to the original patches: > - prereqs are not tested using test_expect_success as they were in Pieter's > original patches, but using a new function called test_set_bin_prereq. I > wrote > this before the gdb prereq was added, hence the different way to set it. > Indeed preferrable to using `test_expect_success' due to no longer overzealously reporting missing prereqs as failures, as well as getting rid of some duplication; This should also be used in the atomicity tests. > - some fixes in Pieter's patches so that it actually works when gpg is not > installed. Can't exactly remember what (...but you can just check his > original > patches), but in the end it was working fine in a chroot without gpg. > Correct. I only added prereqs to actual tests (i.e. calls to `test_expect_success', `test_expect_equal', and `test_expect_equal_file'), while they should also have been added to both the `add_gnupg_home' function and the initialization of ${FINGERPRINT}. > - I added a little patch to smtp-dummy that makes the test suite work again in > Emacs 24 (tested with emacs-pretest 24.0.90). > > Here are the results when running the test suite on my computer: > - without GNU Screen: > All 247 tests behaved as expected (1 expected failure). > 46 tests skipped. > - with GNU Screen: > 242/247 tests passed. > 2 broken tests failed as expected. > 3 tests failed. > > (The 3 failed tests come from some trouble with Emacs 24, I'll try to fix this > later.) > > *Many* thanks to Dmitry Kurochkin and Pieter Praet for their work! > Thanks to you as well! All this duplication of effort is a real shame though. I'd also have preferred your fixes being in separate commits. I'll be commenting on these modified commits where needed, and have re-submitted my original series (rebased to current master) in a new thread [1]. > Regards, > Thomas > > [1] id:"1307016220-17509-1-git-send-email-pieter at praet.org" > [2] id:"1309496122-4965-1-git-send-email-dmitry.kurochkin at gmail.com" > > Dmitry Kurochkin (7): > test: run emacs inside screen > test: avoid using screen(1) configuration files > test: do not set frame width in emacs > test: `notmuch-show-advance-and-archive' with invisible signature > emacs: improve hidden signatures handling in > notmuch-show-advance-and-archive > emacs: remove no longer used functions from notmuch-show.el > emacs: remove unused `point-invisible-p' function > > Pieter Praet (4): > test: add 'GnuPG' prereq to dependent 'crypto' tests > test: add 'Emacs' prereq to dependent 'crypto' tests > test: add 'Emacs' prereq to dependent 'emacs' tests > test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' > tests > > Thomas Jost (2): > test: define a helper function for defining prereqs on executables > test: make smtp-dummy work with Emacs 24 > > emacs/notmuch-lib.el | 15 ------- > emacs/notmuch-show.el | 25 ++++------- > test/crypto | 46 ++++++++++++++------- > test/emacs | 85 ++++++++++++++++++++++++--------------- > test/emacs-large-search-buffer | 9 +++- > test/smtp-dummy.c | 2 +- > test/test-lib.el | 3 - > test/test-lib.sh | 31 +++++++++++++-- > 8 files changed, 127 insertions(+), 89 deletions(-) > > -- > 1.7.6.4 > > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter [1] id:"1320176954-4897-1-git-send-email-pieter at praet.org"