LGTM
On Tue, 29 Nov 2011 02:41:07 +0400, Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote: > The fake missing binary functions check if the binary has already be > added to the diagnostic message to avoid duplicates. Unfortunately, > this check was buggy because the message string does not have the > trailing space. > --- > test/test-lib.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 2861d88..a975957 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -556,7 +556,7 @@ test_declare_external_prereq () { > hash $binary 2>/dev/null || eval " > test_missing_external_prereq_${binary}_=t > $binary () { > - echo -n \"\$test_subtest_missing_external_prereqs_\" | grep -qe \" > $name \" || > + echo -n \"\$test_subtest_missing_external_prereqs_ \" | grep -qe \" > $name \" || > > test_subtest_missing_external_prereqs_=\"\$test_subtest_missing_external_prereqs_ > $name\" > false > }" > -- > 1.7.7.3 > > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch > -- Tomi Ollila !! tomi.ollila at nixu.fi !! +358 400 888 366 Nixu Oy !! http://www.nixu.fi/ !! Keilaranta 15, FI-02150 Espoo, Finland