On Wed, 21 Dec 2011 20:53:08 -0800, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
> * There are a couple of formatting issues (notmuch.1, notmuch-config.1, > notmuch-reply.1). I'm sure there are. Can you be more specific? I suspect I might fix a different set of problems than you found ;). > * The notmuch part command is completely deprecated, so I don't think > there's really any reason to include a man page for it. I'm not sure if removing that would be "doing too many things at once"; it is in the current man page. But maybe that was an oversight? > * There's no man page for restore (notmuch-restore.1). Currently the symlink to notmuch-dump.1.gz is installed at runtime. I agree this is a bit inconvenient for testing; I think it should work to have symlinks in the source just for the convenience of testers. > It also occurs to me while looking through this: do we really need a > separate "setup" command? I guess notmuch-setup is a UI convenience mainly for people who want to re-run setup. It doesn't feel as natural to me to run notmuch without arguments in this case. I couldn't really justify that, though. Thanks for the review, David
