Hi all, this series was borne of curiousity about compiling the notmuch codebase using -std=c99 / -std=c++0x -pedantic options. The C part is split into separate patches to make it easier to see each warning and fix; with C++ I didn't bother so much.
Turns out there are a few specific issues, but overall it's not too bad. However my gut feeling is that some of the fixes to get standards compliance are uglier than just using the GCC extensions. The question is, do we care about anything other than GCC? Comments and discussion welcome; that was the whole point here rather than any serious effort for merging these. (But that can follow if people think this is worth it.) BR, Jani. Jani Nikula (9): build: use -std=c99 -pedantic for C source xutil: #define _POSIX_C_SOURCE to get strdup() lib: fix messages.c build warn lib: HACK: avoid warnings from talloc_steal() cli: fix warning about variadic macros cli: fix another warning about variadic macros util: fix warning about variadic macros lib: use -std=c++0x -pedantic test: smtp-dummy: fixes for -std=c99 -pedantic configure | 4 ++-- lib/database.cc | 3 +-- lib/message.cc | 2 +- lib/messages.c | 6 ++++-- lib/notmuch-private.h | 8 +++++--- lib/tags.c | 5 ++++- lib/thread.cc | 2 +- notmuch-client.h | 9 ++++++--- notmuch-setup.c | 7 +++++-- test/smtp-dummy.c | 4 +++- util/error_util.h | 8 +++++--- util/xutil.c | 2 ++ 12 files changed, 39 insertions(+), 21 deletions(-) -- 1.7.5.4