Quoth Pieter Praet on Jan 19 at 8:19 pm: > Nice feature! I won't be using it myself, but I can imagine it being > *very* useful for those who still feel the need to "delete" email :).
Same here. I probably will use the spam tag, though. > Nitpicking: > > - All other config-related functions and args include the section title > in their name [1], so for the sake of consistency, we might want to > mirror that. Also, the "auto"matic part is pretty much a given. > > So I'd like to suggest replacing all occurences of "auto_exclude_tags" > with "search_exclude_tags" (and simply "exclude_tags" in the args to > `_config_get_list' and `_config_set_list', of course). You are technically correct, the best kind of correct. I'd completely missed this pattern. This should get fixed ASAP, while this feature still has limited adoption. > Unfortunately, this would also partially invalidate your recent NEWS > submission [2]. No worries, though maybe you want to tack an updated version of that patch on the end of your series? > - If the 'search.exclude_tags' option is missing from the config file, > its value is automatically set to "deleted;spam;", which probably isn't > a sane default. Luckily, you've already provided the solution [3]. I'm good either way. I got lost in the discussion of defaults but Jamie assured me everything was okay, so I took the path of least resistance and left things as they were. > - To make new users aware of the config option's existence, we should > prompt them to configure it during setup. Sure. > Patches follow. > > > Peace > > > [1] Eg. `notmuch_config_get_user_name', `notmuch_config_get_new_tags', > `notmuch_config_get_maildir_synchronize_flags', ... > > [2] id:"1326920330-31496-1-git-send-email-amdragon at mit.edu" > > [3] id:"20120117203211.GQ16740 at mit.edu" >
