Hi Austin, A couple of quick notes below, just before I send the new version:
On Fri, Feb 17, 2012 at 13:00, Austin Clements <amdragon at mit.edu> wrote: > One of the biggest wins of using consistent JSON parsing settings is > that this can be replaced with notmuch-show-mm-display-part-inline, > which, as far as I can tell, accomplishes the same thing, but handles > a lot of corner-cases that this doesn't (like crypto and charset > conversion). This would be very desirable indeed, but after taking a stab at it, I've discovered it's a really significant amount of work. The show code relies on a bunch of buffer-local variables regarding crypto and such, which are tricky to factor out into notmuch-lib. Do you think it's acceptable to leave this as future work? > Alternatively, notmuch-mua-get-quotable-parts could be > notmuch-mua-insert-quotable-parts, which would probably simplify > things a bit. ?Your call. I've decided to leave this as get-quotable-parts. This is mostly my personal preference to have a single function do the insertions when possible, which I think makes the flow more obvious. > Is message-cite-original guaranteed to leave point in a reasonable > place for this or should we create our own marker above (probably > after the if re-search-backward..) and use it here to get point to the > right place? It turns out it actually wasn't, which is why MML tags weren't getting escaped twice. I've fixed this.