On Tue, Oct 30 2012, Jani Nikula <jani at nikula.org> wrote: > Hi all, v6 of [1] with plenty of small changes addressing Austin's > review [2], [3], [4], and [5]. See my replies to Austin for what I've > agreed to change, and what I've chosen to ignore and why. > > The single biggest change is the requirement to have some delimiter(s) > between keywords, which allowed simplification of keyword > matching. Consequently match_keyword() and parse_keyword() functions in > patch 2/9 have changed considerably. > > There are a few ways to examine the changes since v5. My public repo at > [6] has branches topic-parse-time-string-v5 (rebased to master) and > topic-parse-time-string-v6, and [7] should provide a fancy colorful diff > between the two. The same but less fancy diff is also at the end of this > cover letter. > > Change by change commits to the parser and test tool can also be found > at [8]. The source files there are copied verbatim to patches 2/9 and > 3/9.
LGTM > > BR, > Jani. > Tomi > [1] id:cover.1350854171.git.jani at nikula.org > [2] id:20121022081444.GM14861 at mit.edu for patch 2/9 > [3] id:20121023042326.GP14861 at mit.edu for patch 4/9 > [4] id:20121023045255.GQ14861 at mit.edu for patch 6/9 > [5] id:20121024210841.GU14861 at mit.edu for patch 8/9 > [6] https://gitorious.org/jani/notmuch > [7] > https://gitorious.org/jani/notmuch/commit/06c76eb4181bc88eccabc419c690046682125d7a/diffs/ef5e8d111748784433f4b80c9e5378f0c1a57319 > [8] https://gitorious.org/parse-time-string/parse-time-string > > Jani Nikula (9): > build: drop the -Wswitch-enum warning > parse-time-string: add a date/time parser to notmuch > test: add new test tool parse-time for date/time parser > test: add smoke tests for the date/time parser module > build: build parse-time-string as part of the notmuch lib and static > cli > lib: add date range query support > test: add tests for date:since..until range queries > man: document the date:since..until range queries > NEWS: date range search support > > Makefile | 2 +- > Makefile.local | 2 +- > NEWS | 12 + > configure | 2 +- > lib/Makefile.local | 3 +- > lib/database-private.h | 1 + > lib/database.cc | 5 + > lib/parse-time-vrp.cc | 61 ++ > lib/parse-time-vrp.h | 40 + > man/man7/notmuch-search-terms.7 | 150 +++- > parse-time-string/Makefile | 5 + > parse-time-string/Makefile.local | 12 + > parse-time-string/README | 9 + > parse-time-string/parse-time-string.c | 1503 > +++++++++++++++++++++++++++++++++ > parse-time-string/parse-time-string.h | 102 +++ > test/Makefile.local | 7 +- > test/basic | 2 +- > test/notmuch-test | 2 + > test/parse-time-string | 78 ++ > test/parse-time.c | 314 +++++++ > test/search-date | 21 + > 21 files changed, 2315 insertions(+), 18 deletions(-) > create mode 100644 lib/parse-time-vrp.cc > create mode 100644 lib/parse-time-vrp.h > create mode 100644 parse-time-string/Makefile > create mode 100644 parse-time-string/Makefile.local > create mode 100644 parse-time-string/README > create mode 100644 parse-time-string/parse-time-string.c > create mode 100644 parse-time-string/parse-time-string.h > create mode 100755 test/parse-time-string > create mode 100644 test/parse-time.c > create mode 100755 test/search-date > > -- > 1.7.10.4
