When tagging from search view in emacs there is a race condition: it tags all messages in the thread even ones which arrived after the search was made. This can cause dataloss (if, for example, a thread is archived it could archive messages the user has never seen).
Mark this test known broken. --- test/emacs | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 44f641e..6246177 100755 --- a/test/emacs +++ b/test/emacs @@ -122,6 +122,29 @@ test_emacs "(notmuch-search \"$os_x_darwin_thread\") output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize) test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)" +test_begin_subtest "Tag all matching messages from search view" +test_subtest_known_broken +notmuch tag +test-tag-race from:cworth +test_emacs "(notmuch-search \"tag:test-tag-race\") + (notmuch-test-wait)" +notmuch tag +test-tag-race "id:1258471718-6781-2-git-send-email-dottedmag at dottedmag.net" +test_emacs "(execute-kbd-macro \"*+test-tag-race-2\")" +output=$(notmuch count tag:test-tag-race-2) +test_expect_equal "$output" "12" +notmuch tag -test-tag-race '*' +notmuch tag -test-tag-race-2 '*' + +test_begin_subtest "Change tags from search view: another message arriving after thread lookup" +test_subtest_known_broken +typsos_id="878we4qdqf.fsf at yoom.home.cworth.org" +typsos_thread=$(notmuch search --output=threads id:$typsos_id) +test_emacs "(notmuch-search \"$typsos_thread\") + (notmuch-test-wait)" +add_message "[subject]=\"new-thread-message\"" "[date]=\"Sat, 01 Jan 2000 12:00:00 -0000\"" "[body]=\"new-thread-message\"" "[in-reply-to]=\"<$typsos_id>\"" +test_emacs "(execute-kbd-macro \"+tag-from-search-view -unread\")" +output=$(notmuch search tag:tag-from-search-view | notmuch_search_sanitize) +test_expect_equal "$output" "thread:XXX 2009-11-18 [2/3] Ingmar Vanhassel, Carl Worth| Notmuch Test Suite; [notmuch] [PATCH] Typsos (inbox tag-from-search-view unread)" + test_begin_subtest "Add tag from notmuch-show view" test_emacs "(notmuch-show \"$os_x_darwin_thread\") (execute-kbd-macro \"+tag-from-show-view\")" -- 1.7.9.1