On Sun, Mar 31 2013, Daniel Bergey wrote: >>From fbaf5c568876a6f1e3d8c02446bd83331b6325f0 Mon Sep 17 00:00:00 2001 > From: Daniel Bergey <bergey at alum.mit.edu> > Date: Thu, 26 Jul 2012 15:44:01 -0400 > Subject: [PATCH] emacs: functions to import sender or recipients into BBDB > >>From a show buffer, notmuch-bbdb/snarf-from imports the sender into > bbdb. notmuch-bbdb/snarf-to imports all recipients. Newly imported > contacts are reported in the minibuffer / Messages buffer. > > Both functions use the BBDB parser to recognize email address formats. > ---
LGTM, although git commit --amend is needed after git am to clean the junk in commit message (just deleting content). Tomi > This differs from the last version of the patch only in whitespace. In > addition to changes pointed out by Tomi Ollila, I fixed a ')' on a line > alone, and aligned the lines of notmuch-bbdb/header-by-name. > > I've been using this code (prior to whitespace changes) for a month and > a half, as far as testing goes. > > I wonder if I can get whitespace-mode to warn me about double-spacing.... > emacs/notmuch-address.el | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el > index 2bf762b..32c8490 100644 > --- a/emacs/notmuch-address.el > +++ b/emacs/notmuch-address.el > @@ -96,6 +96,47 @@ line." > (when (notmuch-address-locate-command notmuch-address-command) > (notmuch-address-message-insinuate)) > > +;; functions to add sender / recipients to BBDB > + > +(defun notmuch-bbdb/snarf-headers (headers) > + ;; Helper function to avoid code duplication in the two below > + ;; headers should have the same format as bbdb-get-addresses-headers > + > + ;; bbdb-get-addresses reads these > + ;; Ugh, pass-by-global > + (let ((addrs (bbdb-get-addresses nil nil 'notmuch-bbdb/get-header-content)) > + (bbdb-get-addresses-headers headers) ; headers to read > + (bbdb-gag-messages t)) ; suppress m/n processed message) > + (bbdb-update-records addrs t t)) > + > + (defun notmuch-bbdb/snarf-from () > + "Import the sender of the current message into BBDB" > + (interactive) > + (notmuch-bbdb/snarf-headers > + (list (assoc 'authors bbdb-get-addresses-headers)))) > + > +(defun notmuch-bbdb/snarf-to () > + "Import all recipients of the current message into BBDB" > + (interactive) > + (notmuch-bbdb/snarf-headers > + (list (assoc 'recipients bbdb-get-addresses-headers)))) > + > +(defvar notmuch-bbdb/header-by-name > + ;; both are case sensitive > + '( ("From" . :From) > + ("To" . :To) > + ("CC" . :Cc) > + ("BCC" . :Bcc) > + ("Resent-From" . nil) > + ("Reply-To" . nil) > + ("Resent-To" . nil) > + ("Resent-CC" . nil)) > + "Alist for dispatching header symbols as used by notmuch-show-get-header > +from strings as used by bbdb-get-addresses") > + > +(defun notmuch-bbdb/get-header-content (name) > + (notmuch-show-get-header (cdr (assoc name notmuch-bbdb/header-by-name)))) > + > ;; > > (provide 'notmuch-address) > -- > 1.7.10.4 > > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch