On Sat, Apr 13, 2013 at 1:14 AM, Tomi Ollila <tomi.ollila at iki.fi> wrote: > On Sat, Apr 13 2013, Felipe Contreras <felipe.contreras at gmail.com> wrote: > >> On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras >> <felipe.contreras at gmail.com> wrote: >>> Signed-off-by: Felipe Contreras <felipe.contreras at gmail.com> >>> --- >>> debian/control | 14 ++++++++++++++ >>> debian/notmuch-ruby.install | 1 + >>> debian/rules | 9 +++++++++ >>> 3 files changed, 24 insertions(+) >>> create mode 100644 debian/notmuch-ruby.install >> >> No comments? Should I push this? > > How do we ensure that ruby package is working in every release; > there seems to be no tests for it ?
We probably should have tests, but how is that relevant to this patch? The code is already there, and distributions are already shipping it: https://projects.archlinux.org/svntogit/community.git/plain/trunk/PKGBUILD?h=packages/notmuch If there's reason to be worried about shipping something that doesn't work, too late, we are already shipping it. And that's orthogonal to this patch, shouldn't prevent it to be merged. Cheers. -- Felipe Contreras
