I have a slight preference for making it do the comment (ie reverse the list). My reason is that we have some other cases such as notmuch-tag-format that apply the first match, so users might be used to having the specific first and the more general later.
It also has a small advantage of being less disruptive but, given that I don't think any of us realised it changed, I guess most people aren't using multiple matches. Best wishes Mark On Fri, 02 May 2014, David Edmondson <dme at dme.org> wrote: > The documentation for `notmuch-search-line-faces' says: > >> The attributes defined for matching tags are merged, with later >> attributes overriding earlier. > > A comment in `notmuch-search-color-line', which implements this, says: > >> ;; Reverse the list so earlier entries take precedence > > Clearly these two are at odds. The implementation of > `notmuch-search-color-line' follows the comment. That is, earlier > entries in the list take precedence. > > The original implementation of `notmuch-search-color-line' followed the > documentation of the user-visible variable, but this was changed by > commit 60ebc849 in July 2012. > > I'm inclined to go with the documentation and change the implementation, > but this could obviously ruin things for some users until they reorder > their settings. > > Thoughts? > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch