Tomi Ollila <tomi.ollila at iki.fi> writes: > On Tue, Apr 09 2013, David Bremner wrote: >> There seems to be a few warnings: >> >> In notmuch-bbdb/snarf-from: >> notmuch-address.el:116:26:Warning: reference to free variable >> `bbdb-get-addresses-headers' >> >> In notmuch-bbdb/snarf-to: >> notmuch-address.el:122:29:Warning: reference to free variable >> `bbdb-get-addresses-headers' >> >> In end of data: >> notmuch-address.el:143:1:Warning: the following functions are not known to be >> defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header >> >> Do we need a few defvars? > > For the above set, something like: > > (defvar bbdb-get-addresses-headers) > > (declare-function notmuch-show-get-header "notmuch-show" (header &optional > props)) > > (declare-function bbdb-get-addresses "bbdb-com" > (only-first-address > uninteresting-senders > get-header-content-function > &rest get-header-content-function-args)) > > (declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p > offer-to-create))
As I'd like to see this in notmuch I made the change. The patch is attached. As it is my first contribution to notmuch at all: Just tell me if I'm supposed to do it in any other way. LG basti -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-emacs-functions-to-import-sender-or-recipient-into-B.patch Type: text/x-diff Size: 3030 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140704/32791fd1/attachment.patch>