Hello, I'm neither a notmuch user or proficient in C++. However, I noticed a bug while working on public-inbox (in Perl) which shares Xapian thread linking logic with notmuch, and I suspect notmuch is affected by the same problem as public-inbox.
The problem is in the _merge_threads function in add-message.cc While the Xapian::PostingIterator for loser is iterating, the Xapian DB is being modified by replace_document via _notmuch_message_sync. This was causing DatabaseCorruptError exceptions in public-inbox with my dataset. I fixed it in public-inbox by stashing docid scalars into a Perl array while iterating with the PostingIterator, and then doing lookups + replacements independently of the PostingIterator by iterating through the Perl array: https://public-inbox.org/meta/20180227221302.7308-...@80x24.org/raw I initially thought this was a bug in the glass backend, but I've also hit it with chert. I have a standalone Perl script to reproduce the bug at https://yhbt.net/skel.bug.perl and 81M gzipped dataset which reproduces the problem at https://yhbt.net/skel.bug.gz (each line is: MID [REFERENCES-SEPARATED-BY-SPACES]) Usage: For failure: curl https://yhbt.net/skel.bug.gz | zcat | perl -w /path/to/skel.bug.perl For success: curl https://yhbt.net/skel.bug.gz | zcat | \ BATCH_SIZE=1000 perl -w /path/to/skel.bug.perl _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch