Johan Parin <johanpa...@gmail.com> writes: > + > + if (notmuch_database_get_config (notmuch, "show.extra_headers", > + &extra_headers) != NOTMUCH_STATUS_SUCCESS) > + return;
Apologies for being late to the discussion of where to store the configuration. So far we have only stored configuration in the database where it affected the behaviour of the library API. I know some people (e.g. dkg) have suggested it would be better to store all of the configuration in the database for consistency, while others are disgruntled that some of the configuration is not editable with text editor. The approach here would represent a change, which I'm not necessarily against, but I think we need to think it through. > + > + header_list = g_mime_object_get_header_list (GMIME_OBJECT(message)); > + > + tofree = extra_headers; It's somewhat a matter of taste, but I would rather introduce a variable for the pointer to be mutated by strsep, and call free (extra_headers) below _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch